Fix issue in TLS_hmac size calculation#9825
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an integer overflow vulnerability in the TLS_hmac() function where arithmetic operations on word32 values could wrap around when input size approaches UINT32_MAX, potentially causing HMAC operations to process incorrect buffer lengths.
Changes:
- Added overflow checks using
WC_SAFE_SUM_WORD32before performing size calculations inTLS_hmac() - Replaced inline arithmetic expressions with pre-computed
totalSzvariable to prevent overflow - Added comprehensive test case
test_tls_hmac_size_overflowto verify overflow detection
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tls.c | Implements overflow protection by pre-computing total size with safety checks and returning BUFFER_E on overflow |
| tests/api/test_hmac.c | Adds test case that exercises overflow conditions with values near UINT32_MAX |
| tests/api/test_hmac.h | Declares new test function and registers it in test macro |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Jenkins retest this please |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Fixes an overflow issues in TLS_hmac().
Credit for finding issue to:
Fixes zd21240
Testing
Added test case
test_tls_hmac_size_overflowChecklist